Fixes saving of multi-CIF

* renaming of data_ names did not work in multi-CIF
dkratzert · Sep 24, 2023 · 1ff1b76 · 1ff1b76
1 parent 9b73091
commit 1ff1b76
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/finalcif/appwindow.py b/finalcif/appwindow.py
@@ -1208,7 +1208,8 @@ def save_current_cif_file(self) -> Union[bool, None]:
         if not self.cif:
             # No file is opened
             return None
-        self.cif.rename_data_name(''.join(self.ui.datanameComboBox.currentText().split(' ')))
+        if not self.cif.is_multi_cif:
+            self.cif.rename_data_name(''.join(self.ui.datanameComboBox.currentText().split(' ')))
         self.store_data_from_table_rows()
         self.save_ccdc_number()
         try:

diff --git a/finalcif/cif/cif_file_io.py b/finalcif/cif/cif_file_io.py
@@ -613,8 +613,7 @@ def rename_data_name(self, newname: str = ''):
         Renames data_ tags to the newname. Also _vrf tags are renamed accordingly.
         http://journals.iucr.org/services/cif/checking/checkfaq.html
         """
-        # Have to use ord(), because Python 3.6 has not str.isascii():
-        newname = ''.join([i for i in newname if ord(i) < 127])
+        newname = ''.join([i for i in newname if i.isascii()])
         self.block.name = newname
         for item in self.block:
             if item.pair is not None: