-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SI multilingual #84
base: master
Are you sure you want to change the base?
SI multilingual #84
Conversation
It allows to get the description of the synset in a different language than the one used for disambiguation (the one of the text) useful for translation or help to understand the text
Jenkins, can you test this please? |
Can one of the admins verify this patch? |
Jenkins, can you test this please? |
Thanks for the PR. It took us a while to react since we first looked into fixing the automatic build and enabling our Jenkins to do PR builds. @logological Jenkins can now build PRs if asked politely to do so ;) |
Hmm... room for improvement. |
Jenkins still needs a bit of fine-tuning, so please excuse issue spam. Jenkins, can you test this please? |
Hm, looks like this PR is incomplete in the sense that it does not update all relevant modules with the updated signature of the |
@OverRide public String getSenseDescription(String senseId, boolean seclang) throws SenseInventoryException { return getSenseDescription(senseId); }
Jenkins, can you test this please? |
It allows to get the description of the synset in a different language
than the one used for disambiguation (the one of the text) useful for
translation or help to understand the text