Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#267 Add new files to excludes section of apache-rat-plugin #268

Merged

Conversation

mawiesne
Copy link
Contributor

@mawiesne mawiesne commented Nov 4, 2023

  • Adds new files introduced during recent changes, eg for Github actions integration
  • Adjusts GH CI action to run Maven build step with the rat-check profile switched on

What's in the PR

How to test manually

  • mvn clean install -Prat-check

Automatic testing

  • PR includes unit tests

Documentation

  • PR updates documentation

@mawiesne mawiesne self-assigned this Nov 4, 2023
@mawiesne mawiesne requested review from rzo1 and reckart November 4, 2023 07:24
@mawiesne mawiesne added this to the 2.0.0 milestone Nov 4, 2023
- adds new files introduced during recent changes, eg for Github actions integration
- adjusts GH actions to run with the rat-check profile switched on
@mawiesne mawiesne force-pushed the #267-add-new-files-to-excludes-section-of-apache-rat-plugin branch from ed96e37 to b0c8250 Compare November 4, 2023 07:26
Copy link
Contributor

@rzo1 rzo1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't know if a header is required for these files, @reckart - if so, we should add them instead of excluding them.

@reckart
Copy link
Member

reckart commented Nov 5, 2023

Typically, headers should be present in all files which allow having them (i.e. where the format does not technically prohibit it). That said, those build config files are probably hardly copyrightable since they are pretty much the same or at least very similar across many projects due to the technical processes that they drive. I'd say do what you feel is right.

@mawiesne mawiesne merged commit f289b14 into master Nov 6, 2023
4 checks passed
@mawiesne mawiesne deleted the #267-add-new-files-to-excludes-section-of-apache-rat-plugin branch November 6, 2023 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants