Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GH build badge to README.md #232

Merged
merged 1 commit into from
Oct 19, 2023
Merged

Conversation

mawiesne
Copy link
Contributor

... as the title says.

@mawiesne mawiesne requested review from reckart and rzo1 October 19, 2023 08:43
@mawiesne
Copy link
Contributor Author

mawiesne commented Oct 19, 2023

@reckart See below in the checks, UKP OSS Jenkins is still around, even it is a new PR.

@reckart
Copy link
Member

reckart commented Oct 19, 2023

Ok, gotcha - but the failure should not block the merge.

@mawiesne
Copy link
Contributor Author

Merging is blocked

:/

@reckart
Copy link
Member

reckart commented Oct 19, 2023

The status check on the GitHub side was already disabled. Now I also disabled the Jenkins jobs on the Jenkins side - no status checks from it should appear anymore.

@mawiesne
Copy link
Contributor Author

mawiesne commented Oct 19, 2023

@reckart Could you grant @rzo1 and me the right to re-trigger build checks here? Atm, we can't do this.

@reckart
Copy link
Member

reckart commented Oct 19, 2023

@mawiesne please check again with your upgraded permissions.

@rzo1
Copy link
Contributor

rzo1 commented Oct 19, 2023

please check again with your upgraded permissions.

I can now see the button ;-) thx.

@mawiesne mawiesne merged commit fbf0b49 into master Oct 19, 2023
6 of 7 checks passed
@mawiesne mawiesne deleted the Add-GH-build-badge-to-README.md branch October 19, 2023 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants