Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove commons-codec dependency in favor of JDK's own Base64 codec #249

Closed
mawiesne opened this issue Oct 29, 2023 · 0 comments
Closed

Remove commons-codec dependency in favor of JDK's own Base64 codec #249

mawiesne opened this issue Oct 29, 2023 · 0 comments
Assignees
@mawiesne
Labels
dependencies Pull requests that update a dependency file
Milestone
2.0.0

Comments

@mawiesne
Copy link
Contributor

The classes RevisionDecoder and RevisionEncoder reference classes from the Apache's commons-codec dependency to achieve Base64 en-/decoding. Since Java 8 this is not longer necessary, as we can use a "built-in" solution brought via the JRE .

Thus, we can eliminate the need to have this reference to commons-codec (in old versions).

Aims:

  • Get rid of this binding.
mawiesne added a commit that referenced this issue Oct 29, 2023
@mawiesne
#249 Remove commons-codec dependency in favor of JDK's own Base64 codec
7d9f4a4 
- switches to `java.util.Base64` instead of `org.apache.commons.codec.binary.Base64`
- removes (hard) dependency commons-codec from `dkpro-jwpl-revisionmachine`
@mawiesne mawiesne self-assigned this Oct 29, 2023
@mawiesne mawiesne added this to the 2.0.0 milestone Oct 29, 2023
@mawiesne mawiesne added the dependencies Pull requests that update a dependency file label Oct 29, 2023
mawiesne added a commit that referenced this issue Oct 30, 2023
@mawiesne
#249 Remove commons-codec dependency in favor of JDK's own Base64 cod…
600d287 
…ec (#250)

- switches to `java.util.Base64` instead of `org.apache.commons.codec.binary.Base64`
- removes (hard) dependency commons-codec from `dkpro-jwpl-revisionmachine`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mawiesne mawiesne

Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
2.0.0
Development

No branches or pull requests
1 participant
@mawiesne