Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce checkstyle #164

Closed
reckart opened this issue Jul 3, 2018 · 1 comment
Closed

Introduce checkstyle #164

reckart opened this issue Jul 3, 2018 · 1 comment
Assignees
Milestone

Comments

@reckart
Copy link
Member

reckart commented Jul 3, 2018

We have a Maven-based checkstyle configuration compatible with the DKPro style profiles in DKPro Core. This could be transferred to JWPL.

@mawiesne
Copy link
Contributor

mawiesne commented Jul 3, 2018

Should this be part of milestone 1.2.0 or shall we put it into 1.2.1?

Feel free to assign it.

@reckart reckart added this to the 1.3.0 milestone Jul 3, 2018
@reckart reckart modified the milestones: 1.3.0, Feature backlog Jan 4, 2021
@reckart reckart self-assigned this Oct 31, 2023
@reckart reckart modified the milestones: Feature backlog, 2.0.0 Oct 31, 2023
reckart added a commit that referenced this issue Oct 31, 2023
- Added checkstyle profile using the rules from DKPro Core
reckart added a commit that referenced this issue Oct 31, 2023
- Add style config template and script to install it
reckart added a commit that referenced this issue Oct 31, 2023
- Change GH action to build up to the verify stage which includes checkstyle
reckart added a commit that referenced this issue Oct 31, 2023
- Organize imports
reckart added a commit that referenced this issue Oct 31, 2023
- Auto-format dkpro-jwpl-api
reckart added a commit that referenced this issue Oct 31, 2023
- Auto-format dkpro-jwpl-datamachine
reckart added a commit that referenced this issue Oct 31, 2023
- Auto-format dkpro-jwpl-mwdumper
reckart added a commit that referenced this issue Oct 31, 2023
- Auto-format dkpro-jwpl-parser
reckart added a commit that referenced this issue Oct 31, 2023
- Auto-format dkpro-jwpl-revisionmachine
reckart added a commit that referenced this issue Oct 31, 2023
- Auto-format dkpro-jwpl-timemachine
reckart added a commit that referenced this issue Oct 31, 2023
- Auto-format dkpro-jwpl-tutorial
reckart added a commit that referenced this issue Oct 31, 2023
- Auto-format dkpro-jwpl-util
reckart added a commit that referenced this issue Oct 31, 2023
- Auto-format dkpro-jwpl-wikimachine
reckart added a commit that referenced this issue Oct 31, 2023
- Fix remaining checkstyle issues
- Use try-with-resources in some places
- Add re-generate hashcode/equals where only equals was implemented without hashcode
reckart added a commit that referenced this issue Oct 31, 2023
@reckart reckart closed this as completed Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants