-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Is de.tudarmstadt.ukp.wikipedia.dist module still needed? #130
Comments
I am not really sure what this module was used for. |
Anybody an idea? Otherwise, we might just get rid of it. |
I'd say it way used to build a kind of fat JAR via a Maven assembly. @ferschke did that if I remember right. For me, I'm +1 on removing it. |
Yes, that was used to create runnable fatjars. If those are no longer used, -Oliver
|
We distribute jars-with-dependencies via Maven Central. Does the dist module have any advantage over this? |
Is the dist module the way this " jars-with-dependencies" is created? Who is this jars-with-deps for anyway? |
Good question. @ferschke I think you performed the last release. Are the jars-with-dependencies on Maven Central created with the dist module? |
Apparently not: https://github.com/dkpro/dkpro-jwpl/search?utf8=✓&q=jar-with-dependencies Looks like each module creates it's own. |
That was really just for the fatjars that we used to manually upload to google code. No reason to keep this module. |
Now it's gone. |
Is this module still up-to-date and do we still need it?
The text was updated successfully, but these errors were encountered: