Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is de.tudarmstadt.ukp.wikipedia.dist module still needed? #130

Closed
daxenberger opened this issue Dec 15, 2015 · 10 comments
Closed

Is de.tudarmstadt.ukp.wikipedia.dist module still needed? #130

daxenberger opened this issue Dec 15, 2015 · 10 comments
Milestone

Comments

@daxenberger
Copy link
Member

Is this module still up-to-date and do we still need it?

@zesch
Copy link
Member

zesch commented Dec 28, 2015

I am not really sure what this module was used for.

@daxenberger
Copy link
Member Author

Anybody an idea? Otherwise, we might just get rid of it.

@reckart
Copy link
Member

reckart commented Dec 28, 2015

I'd say it way used to build a kind of fat JAR via a Maven assembly. @ferschke did that if I remember right. For me, I'm +1 on removing it.

@ferschke
Copy link
Member

Yes, that was used to create runnable fatjars. If those are no longer used,
this can be removed.

-Oliver
On Dec 28, 2015 11:18 PM, "Richard Eckart de Castilho" <
[email protected]> wrote:

I'd say it way used to build a kind of fat JAR via a Maven assembly.
@ferschke https://github.com/ferschke did that if I remember right. For
me, I'm +1 on removing it.


Reply to this email directly or view it on GitHub
#130 (comment).

@daxenberger
Copy link
Member Author

We distribute jars-with-dependencies via Maven Central. Does the dist module have any advantage over this?

@reckart
Copy link
Member

reckart commented Dec 29, 2015

Is the dist module the way this " jars-with-dependencies" is created? Who is this jars-with-deps for anyway?

@daxenberger
Copy link
Member Author

Good question. @ferschke I think you performed the last release. Are the jars-with-dependencies on Maven Central created with the dist module?

@reckart
Copy link
Member

reckart commented Dec 29, 2015

Apparently not: https://github.com/dkpro/dkpro-jwpl/search?utf8=✓&q=jar-with-dependencies

Looks like each module creates it's own.

@ferschke
Copy link
Member

That was really just for the fatjars that we used to manually upload to google code. No reason to keep this module.

daxenberger added a commit that referenced this issue Apr 6, 2016
@daxenberger
Copy link
Member Author

Now it's gone.

@daxenberger daxenberger added this to the 1.1.0 milestone Apr 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants