Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to jbuilder #38

Merged
merged 7 commits into from
Jan 2, 2018
Merged

Switch to jbuilder #38

merged 7 commits into from
Jan 2, 2018

Conversation

djs55
Copy link
Owner

@djs55 djs55 commented Jan 2, 2018

This is a duplicate of #29 from @nojb , rebased to fix the conflict.

@djs55 djs55 merged commit 6036784 into master Jan 2, 2018
@djs55 djs55 deleted the nojb-master branch January 2, 2018 20:50
@nojb
Copy link
Contributor

nojb commented Jan 2, 2018

I just remembered something - strictly speaking the jbuilder build is not backwards-compatible because it defines a single sha ocamlfind package, as opposed as the hand-written Makefile which defined sha.sha1, sha.sha256, sha.sha512 IIRC.

Should we do something about it?

@djs55
Copy link
Owner Author

djs55 commented Jan 2, 2018 via email

@nojb
Copy link
Contributor

nojb commented Jan 3, 2018

I do not think it is worth the trouble. I took a quick look at the reverse dependencies of sha and there is only one (vhd-tool.0.12.0) that refers to the now-non-existent package sha.sha1. All the rest refer to the top-level package sha which works fine with the jbuilder setup. I don't find the idea of adding dummy (empty) ocamlfind packages very appealing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants