Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for pydantic-settings > 2.2.0 #38

Merged
merged 8 commits into from
Feb 25, 2024

Conversation

djpugh
Copy link
Owner

@djpugh djpugh commented Feb 25, 2024

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

Have you updated the appropriate files

Please check that you have (if appropriate):

  • Updated the documentation
  • Updated README.md
  • Executed pre-commit run --all-files with no errors
  • The change is fully covered by automated unit tests

What is the current behavior?

Pin pydantic-settings to <2.2.0 due to issue highlighted in pydantic/pydantic-settings#245

Issue: #33

What is the new behavior?

  • Added wrapper for 2.2.0 DotEnvSettings with new SettingsConfigDict parameter for dotenv_extra that defaults to ignore, reversing the behaviour introduced in 2.2.0
  • Refactored FileConfigSettingsSource to use the new Json/Yaml/Toml handlers (including wrapper to instantiate at call time rather than initialisation time)
  • Pinned pydantic-settings to be >=2.2.0, <2.3.0 given previous introduction of breaking changes in a minor version

Other information

@djpugh djpugh enabled auto-merge (squash) February 25, 2024 17:01
Copy link

Quality Gate Passed Quality Gate passed

Issues
2 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@djpugh djpugh merged commit 793bf11 into main Feb 25, 2024
41 of 56 checks passed
@djpugh djpugh deleted the fix/33-bug-validation-errors branch February 25, 2024 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant