Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding handling for namespace repo defaults #35

Merged
merged 4 commits into from
Feb 25, 2024

Conversation

djpugh
Copy link
Owner

@djpugh djpugh commented Feb 23, 2024

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

Have you updated the appropriate files

Please check that you have (if appropriate):

  • Updated the documentation
  • Updated README.md
  • Executed pre-commit run --all-files with no errors
  • The change is fully covered by automated unit tests

What is the current behavior?

Currently cannot easily set/enforce namespace validation from the environment variables (e.g. if repo created)

What is the new behavior?

  • Added namespace validation handling to codebase initialisation
  • Added default behaviour (if unset, but folder exists in codebase folder then use it)
  • Added environment variable handling (e.g. Enum as str not int so can parse)

Other information

@github-actions github-actions bot added the fix label Feb 23, 2024
Copy link

codecov bot commented Feb 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.00%. Comparing base (1b24141) to head (4db5af6).
Report is 4 commits behind head on main.

❗ Current head 4db5af6 differs from pull request most recent head 4b48cbc. Consider uploading reports for the commit 4b48cbc to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #35      +/-   ##
==========================================
+ Coverage   78.42%   79.00%   +0.58%     
==========================================
  Files          53       53              
  Lines        1738     1748      +10     
==========================================
+ Hits         1363     1381      +18     
+ Misses        375      367       -8     
Flag Coverage Δ
tests 79.00% <100.00%> (+0.58%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@djpugh djpugh added feature and removed fix labels Feb 23, 2024
@djpugh djpugh enabled auto-merge (squash) February 23, 2024 18:18
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@djpugh djpugh merged commit f3769f1 into main Feb 25, 2024
44 of 45 checks passed
@djpugh djpugh deleted the fix/namespace_validator_from_env branch February 25, 2024 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant