This repository has been archived by the owner on Jan 26, 2024. It is now read-only.
Prevent using a wlr_layer_surface after destroying it #421
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the
createlayersurface
callback is hit whenselmon
is NULL thenwlr_layer_surface
is destroyed by callingwlr_layer_surface_v1_destroy()
. This change simply adds a return at that point, to prevent a crash caused by dereferencing the destroyed variable.The crash in question can be reproduced easily by unplugging or turning off all monitors while running
swaync
, waiting a few seconds and then plugging them back in. It is likely possible to cause this with things other thanswaync
, but that was the application that triggered it for me.