Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dont format html in attributes #1001

Merged

Conversation

oliverhaas
Copy link
Contributor

Pull Request Check List

Resolves: #1000

  • Added tests for changed code.
  • Updated documentation for changed code.

Updating docs not really necessary as far as I can see, since it is just a bugfix in my eyes. Let me know if I misunderstood that task.

Copy link

netlify bot commented Nov 2, 2024

Deploy Preview for djlint canceled.

Name Link
🔨 Latest commit b32dc43
🔍 Latest deploy log https://app.netlify.com/sites/djlint/deploys/6726109c7238cd0008749a55

@oliverhaas oliverhaas changed the title fix: dont fromat html in attributes fix: dont format html in attributes Nov 2, 2024
@monosans
Copy link
Member

monosans commented Nov 2, 2024

Hey, @oliverhaas! Thank you for this PR!

@monosans monosans enabled auto-merge (squash) November 2, 2024 11:45
@monosans monosans merged commit 35a5a78 into djlint:master Nov 2, 2024
8 checks passed
@oliverhaas oliverhaas deleted the fix/dont-format-html-in-attributes branch November 2, 2024 12:04
@alphatownsman
Copy link

what would be the best way to fix case in #792 ?

e.g.

<span class="r"
      _="<input/>">
</span>

@oliverhaas
Copy link
Contributor Author

oliverhaas commented Dec 27, 2024

what would be the best way to fix case in #792 ?

e.g.

<span class="r"
      _="<input/>">
</span>

Please try out the current master branch, now that this is merged. (EDIT: Actually, this should be in the current release I think.)

@alphatownsman
Copy link

1.36.4 seems working great. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] [Formatter] html strings inside html attributes not properly formatted
3 participants