Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We already have a
Stream.ShutdownWithErr
mechanism, which propagates a custom error.There's also a
Stream.Cancel
method. However, there should be aStream.CancelWithErr
method to allow propagation of a custom error.For example, let's say I'm reading from an http response, and writing the bytes to a stream. If there's an error reading the response, I specifically want to
Cancel
the stream (as opposed to callingShutdown
). But, any clients of the stream will just receive a genericErrCanceled
, which is not super helpful. I want to be able to propagate the http error back to the stream clients.