DictionaryField does not call the get_prep_value method of VirtualField before saving to DB

[ktosiek]

I have a custom field that uses to_python/get_prep_value to (de)serialize a custom object.
Something like HandField from https://docs.djangoproject.com/en/1.8/howto/custom-model-fields/.

When I'm using that field in hstore.DictionaryField schema my object is cast to string which is not a sensible representation. I was expecting DictionaryField to clean values with get_prep_value before casting them to strings.

[nemesifier]

This looks related to #114.

[nemesifier]

Hi @ktosiek, what were you expecting exactly? Could you help me by giving me an example with:

• model data
• operation performed
• expected behaviour
• actual behaviour

I'm trying to replicate the behaviour you mentioned but I don't notice anything strange, so I need your help to replicate your use case.

[ktosiek]

I've made a repo with an example: https://github.com/ktosiek/django-hstore-issue-123-example.
HandField has dedicated code for serializing Hand to a string, but it looks like django-hstore uses str(value) as the serialization of Hand.

model data: https://github.com/ktosiek/django-hstore-issue-123-example/blob/master/example/example/models.py and https://github.com/ktosiek/django-hstore-issue-123-example/blob/master/example/example/fields.py
expected behaviour is those two tests passing: https://github.com/ktosiek/django-hstore-issue-123-example/blob/master/example/example/tests.py
actual behaviour: the test using my custom field without hstore passes, the other one fails (I think because Hand.__str__ is used for serialization instead of HandField.get_prep_value).

[nemesifier]

hey @ktosiek, what about adapting a simplified version of those tests into django_hstore?

[ktosiek]

It would make more sense, yes :-)
I'll try to do it later today.

[nemesifier]

thank you @ktosiek, whenever you have time, it will be easier to address it and solve it.

Do you think this is in anyway related to #114?

[nemesifier]

PS: see also this section of the docs: http://djangonauts.github.io/django-hstore/#_developers_guide

[ktosiek]

I don't see any relation with #114.