Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missed css_class to TabHolder template #183

Merged
merged 4 commits into from
Jul 24, 2024

Conversation

kosdmit
Copy link
Contributor

@kosdmit kosdmit commented Jul 23, 2024

PR to fix Issue #178

Now we can use css_class TabHolder attribute to add css classes to html element. For example:
adding "justify-content-center" css class to TabHolder gives this result:

<form method="post">
      <ul class="nav nav-tabs justify-content-center">
        <li class="nav-item">
          <a class="nav-link active" href="#custom-name" data-bs-toggle="tab"
            >One</a
          >
        </li>
        <li class="nav-item">
          <a class="nav-link" href="#two" data-bs-toggle="tab">Two</a>
        </li>
      </ul>
...

image

@smithdc1
Copy link
Member

Thanks @kosdmit -- I pushed a change to the tests. If you could let me know that you are happy with these I can then merge this.

@kosdmit
Copy link
Contributor Author

kosdmit commented Jul 24, 2024

If you could let me know that you are happy with these I can then merge this.

I think it's done well, we can do the merge.

@smithdc1 smithdc1 merged commit 235c641 into django-crispy-forms:main Jul 24, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants