removed inline style for CSP compliancy #103
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the patch. 👍 This is on my list to have a look at next time I get some time. In the meantime could you have a look at updating the tests to address the failures? |
Closed
|
@Lueders-Martin -- do you still have time to carry on working on this? |
|
Follow up in #115 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change works in my local project, and removes the CSP issues related to crispy_forms.
However, you might want to check whether the omission of the min-width has any effect, or whether this can be acheived through the different flex-{}-grow- classes. Unfortunately, I am not an expert on bootstrap5 classes.