-
-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Django/Python versions in Automated Tests #100
Conversation
Thanks for this. This looks good to me. I think just one amend needed before I merge this. Could you also update the Line 36 in 2b1a014
As a bonus, I'd also take dropping Django 2.2 at this stage if you wanted update for that as well? |
Updated the automated tests run by Github Actions to only use supported versions and combinations of Python and Django. - Added Python 3.10 to Github automated tests for Django 3.2 and 4.0. - Removed Python 3.6 and Django 2.2/3.1 from tests {deprecated upstream). - Run linters using the latest version of Python (3.10).
I made all the changes you suggested, including removing Django 2.2 and updating the classifiers. Would you also like for me to update publish.yml too, since it has references to Python 3.6? I'm not 100% certain what all that workflow does, so I felt it would be better to check with you first. I'm happy to add publish.yml to this PR or to create a new one -- whichever you'd prefer. Thanks! |
Yes please, let's do that here as well. Thank you!! |
Ok, everything we discussed is complete. Please let me know if anything is else needed before merging. Thanks! |
Hi @jmoppel -- could you pull your other changes into here so we can get the test suite to pass? |
- Python 3.7 is now the minimum required version to installl crispy-bootstrap5. - Removed Django 2.2, 3.1, and Python 3.6 (deprecated upstream) from classifiers. - Removed Python 3.6 from publishing test matrix - Run the deployment process using the latest version of Python (3.10). - Fixed a broken test results file where it incorrectly expected a repeated form-select (test_prepended_appended_select.html)
Done. All tests and linting actions now finish without errors on my fork. |
@jmoppel thanks for all of your efforts. 🏅 |
Updated the automated tests run by Github Actions to only use supported
versions and combinations of Python and Django.