Rely on django-csp's private attribute for nonce #2088
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This refactors how the CSP nonce is fetched. It's now done as a toolbar property and wraps the private attribute request._csp_nonce This avoids the toolbar from generating a nonce that gets injected into the CSP header when the view doesn't expect it to. It also supports using a nonce that is generated from any other point while processing the request, including other middleware.
tim-schilling
commented
Feb 26, 2025
| @@ -42,6 +42,11 @@ def regular_view(request, title): | |||
| return render(request, "basic.html", {"title": title}) | |||
|
|
|||
|
|
|||
| def csp_view(request): | |||
| """Use request.csp_nonce to inject it into the headers""" | |||
| return render(request, "basic.html", {"title": f"CSP {request.csp_nonce}"}) | |||
There was a problem hiding this comment.
The nonce needed to be rendered in the view. I chose to do it here.
tim-schilling
commented
Feb 26, 2025
Comment on lines
+75
to
+76
| for middleware in [MIDDLEWARE_CSP_BEFORE, MIDDLEWARE_CSP_LAST]: | ||
| with self.settings(MIDDLEWARE=middleware): |
There was a problem hiding this comment.
It become important to test with both configurations of middleware. Or at least it will be more important if we stop relying on request._csp_nonce
robhudson
reviewed
Feb 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This refactors how the CSP nonce is fetched. It's now done as a toolbar property and wraps the private attribute
request._csp_nonceThis avoids the toolbar from generating a nonce that gets injected into the CSP header when the view doesn't expect it to. It also supports using a nonce that is generated from any other point while processing the request, including other middleware.
Fixes #2082
Checklist:
docs/changes.rst.