Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: django shortcuts styling #481

Merged
merged 9 commits into from
Jan 6, 2023

Conversation

fsbraun
Copy link
Member

@fsbraun fsbraun commented Jan 5, 2023

This PR reintroduces the styling for django-shortcuts which were deleted with their icons. The icons are not reintroduced and django-shortcuts will use its own icons also with djangocms-admin-style.

Related resources

@codecov
Copy link

codecov bot commented Jan 5, 2023

Codecov Report

Merging #481 (5814549) into master (897f535) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master      #481   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines           33        33           
  Branches         3         3           
=========================================
  Hits            33        33           
Impacted Files Coverage Δ
djangocms_admin_style/__init__.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@DmytroLitvinov
Copy link

Waiting for new release :)

add info to changelog and reademe.md
Copy link
Member

@marksweb marksweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isort isn't happy about something here, but I'm not entirely sure what.

@fsbraun
Copy link
Member Author

fsbraun commented Jan 6, 2023

@marksweb There was a superfluous empty line in setup.py. Removed.

@marksweb
Copy link
Member

marksweb commented Jan 6, 2023

@fsbraun that explains how I looked over it 😂

Copy link
Member

@marksweb marksweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just spotted syntax issues in the readme

fsbraun and others added 3 commits January 6, 2023 17:52
@fsbraun fsbraun merged commit 74fedbc into django-cms:master Jan 6, 2023
@fsbraun
Copy link
Member Author

fsbraun commented Jan 6, 2023

@DmytroLitvinov Please check pypi.

@DmytroLitvinov
Copy link

Thank you, guys 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants