Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update release actions #1469

Merged
merged 5 commits into from
May 19, 2024
Merged

chore: Update release actions #1469

merged 5 commits into from
May 19, 2024

Conversation

fsbraun
Copy link
Member

@fsbraun fsbraun commented May 17, 2024

Description

Related resources

  • #...
  • #...

Checklist

  • I have opened this pull request against master
  • I have added or modified the tests when changing logic
  • I have followed the conventional commits guidelines to add meaningful information into the changelog
  • I have read the contribution guidelines and I have joined #workgroup-pr-review on
    Slack to find a “pr review buddy” who is going to review my pull request.

.github/workflows/publish-to-test-pypi.yml Outdated Show resolved Hide resolved
.github/workflows/publish-to-test-pypi.yml Outdated Show resolved Hide resolved
.github/workflows/publish-to-test-pypi.yml Outdated Show resolved Hide resolved
@fsbraun fsbraun requested a review from marksweb May 18, 2024 05:31
Copy link

codecov bot commented May 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.90%. Comparing base (0402d66) to head (ddcf9e0).
Report is 5 commits behind head on master.

Current head ddcf9e0 differs from pull request most recent head 3bbf44d

Please upload reports for the commit 3bbf44d to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1469      +/-   ##
==========================================
- Coverage   77.05%   76.90%   -0.16%     
==========================================
  Files          75       75              
  Lines        3544     3550       +6     
  Branches      508      570      +62     
==========================================
- Hits         2731     2730       -1     
- Misses        653      660       +7     
  Partials      160      160              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@marksweb marksweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So this looks good. But what's odd is that you've not had to remove an arg that passed the pypi token to the upload action.

@fsbraun fsbraun merged commit 2ac8c15 into master May 19, 2024
82 checks passed
@vinitkumar vinitkumar deleted the chore/release-actions branch November 15, 2024 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants