This repository has been archived by the owner on Jul 31, 2020. It is now read-only.
Move up task 'Override architecture if 64-bit' #304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Move up task 'Override architecture if 64-bit'
The fact 'windows_arch' is set to 32 per default line 10.
The fact 'windows_arch' is used by "Windows | Set path to zabbix.exe" task juste after, so the path zabbix_win_exe_path contain 32bit path. And the override is after.
If we keep the override set_fact after this task : the path 'zabbix_win_exe_path' is not changed and keep this value to 32. And zabbix-agent in 64bit is never installed even if ansible_architecture is 64bit.
Type of change
Move up task 'Override architecture if 64-bit' to override 'windows_arch' value before use it.
Feature Pull Request
Bugfix Pull Request
Docs Pull Request
Fixes an issue
The issue is not visible by ansible. But the main issue is : if the OS archi is 64bit, the version of zabbix-agent version 32bit is always installed.
After the change :
Before it was 'win32'.
Tested with Ansible 2.9.0 on Windows 2016 Server.