Fix tagpass and tagdrop #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
"Also, out of curiosity, what do the pass, drop and specifications do? I can not find any documentation on this. Seems to me it does nothing and could be removed." To be honest, I have no idea. It was available back then with before the 1.x.x version, but not sure if this tagpass and tagdrop are still able to be used. But will merge this pr. Thanks! 👍 |
|
Thanks, tagpass and tagdrop are working fine, I use it in production. Shall I cleanup, and create another PR? |
|
@jgeusebroek Yeah sure! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
tagpass and tagdrop are ignored when not prefixed with inputs.
Type of change
Bugfix Pull Request
Also, out of curiosity, what do the pass, drop and specifications do? I can not find any documentation on this. Seems to me it does nothing and could be removed.