Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace 'ec2_facts' with 'ec2_metadata_facts' to fix a deprecation warning #72

Merged
merged 1 commit into from
Dec 3, 2018

Conversation

Rylon
Copy link
Contributor

@Rylon Rylon commented Dec 3, 2018

Description of PR
Just a one-line change to fix the following deprecation warning:

[DEPRECATION WARNING]: ec2_facts is kept for backwards compatibility but usage is discouraged. The module
 documentation details page may explain more about this rationale.. This feature will be removed in a
future release. Deprecation warnings can be disabled by setting deprecation_warnings=False in
ansible.cfg.

It seems like ec2_metadata_facts is a drop-in replacement for ec2_facts. It was added in Ansible 2.4, which is the minimum version you support with this role, so I think it should be ok?

Thanks!

Type of change
Bugfix Pull Request

@dj-wasabi dj-wasabi merged commit 8e927ff into dj-wasabi:master Dec 3, 2018
@dj-wasabi
Copy link
Owner

Thanks! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants