Remove for-loop in extra-plugin template #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y the task itself. Was causing all extra plugin configurations to be written in each sub-configuration file
|
This seems to be the fix for #22 ? |
… case of multiple instances of same plugin
|
I was careless and didn't check the issue list before submitting the PR. Yes, it was intended as a fix for that issue, but it didn't cover the case @haraldkoch brought up, of multiple instances of the same plugin. I've updated with a change that covers that case as well, by writing all conf into a single file, instead of each plugin into a separate one. |
|
That does solve the problem, and also deals with issue #8 ... |
|
@emersondispatch Thanks!!! |
aarnaud
pushed a commit
to aarnaud/ansible-telegraf
that referenced
this pull request
Oct 24, 2017
Remove for-loop in extra-plugin template
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because this is performed by the task itself. Was causing all extra plugin configurations to be written in each sub-configuration file in telegraf.d