Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support missing agent settings upto telegraf v1.1 #16

Merged
merged 1 commit into from
Dec 30, 2016

Conversation

lhoss
Copy link
Contributor

@lhoss lhoss commented Dec 30, 2016

new feature/settings added in a downward compatible way, so that settings are only added to the config if the telegraf version supports the settings (and using of course the defaults, if the new role vars were not overridden by the ansible user)

@dj-wasabi dj-wasabi merged commit 5036595 into dj-wasabi:master Dec 30, 2016
@dj-wasabi
Copy link
Owner

Thanks! 👍

@lhoss
Copy link
Contributor Author

lhoss commented Dec 30, 2016

ps: I was thinking to allow to deploy a custom telegraf.conf (in many cases easier, also thx to using ENV vars in telegraf.conf, templating it is not always needed)

a very flexible solution would be to simply make the template source (path+filename) configurable , AND of course one can also deploy a pure 'conf' file (the template module then just 'copy's it)

aarnaud pushed a commit to aarnaud/ansible-telegraf that referenced this pull request Oct 24, 2017
support missing agent settings upto telegraf v1.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants