Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add consolidated support for custom names #176

Merged
merged 2 commits into from
Mar 24, 2021
Merged

Add consolidated support for custom names #176

merged 2 commits into from
Mar 24, 2021

Conversation

diwako
Copy link
Owner

@diwako diwako commented Mar 22, 2021

Removal of ACE_name querying.

Instead consolidated custom names possible with variable diwako_dui_main_customName

@diwako diwako added the enhancement New feature or request label Mar 22, 2021
@diwako diwako added this to the 1.9.0 milestone Mar 22, 2021
@BrettMayson
Copy link
Contributor

Personally I use this, and would be sad to see it go.

@diwako
Copy link
Owner Author

diwako commented Mar 23, 2021

The main reason why this change is made is to counter the "Error: no unit" names that several people report. It is a weird phenomenon that just happens and it is impossible to track. Instead we offload it to a new variable which is not in use normally. All you have to do is just write a new variable onto the unit if you need.

https://github.com/diwako/diwako_dui/wiki/Custom-unit-specific-(group)-names

besides, custom names were not yet possible for nametags, one reason why it was discovered for ACE_name being the issue was, namelist showed up wrong, but nametags showed up correct.

@BrettMayson
Copy link
Contributor

Ah ok, we don't use the radar / namelist so we never noticed any issues there. I'd still rather just use ACE_name rather than having to track more variables but if you have to do it then /shrug

@diwako
Copy link
Owner Author

diwako commented Mar 23, 2021

Ah ok, we don't use the radar / namelist so we never noticed any issues there. I'd still rather just use ACE_name rather than having to track more variables but if you have to do it then /shrug

Yeah same. But the issues are just too flaky. I never managed to reproduce it, no one I know with dev skills had those issues. The issue are mostly in units with people without actual dev skills, so it was never possible to debug properly.

@diwako diwako merged commit 6814f5c into master Mar 24, 2021
@diwako diwako deleted the custom_names branch March 24, 2021 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants