datastore: tidy up some byte slice conversions #935
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By adding a couple of `TryFrom<&[u8]>` implementations, we can make use of `RowExt::get_bytea_and_convert` to get things like `TaskId`, `ReportId` or other types that are simple wrappers around fixed-size byte arrays from database rows.
tgeoghegan
force-pushed
the
timg/datastore-bytea-try-from
branch
from
61633bf to
b9d3c52
Compare
branlwyd
approved these changes
Jan 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By adding a couple of
TryFrom<&[u8]>implementations, we can make use ofRowExt::get_bytea_and_convertto get things likeTaskId,ReportIdor other types that are simple wrappers around fixed-size byte arrays from database rows.