Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add option to avoid adding a match-all rule #73

Merged
merged 1 commit into from
Feb 5, 2019

Conversation

Swatinem
Copy link
Contributor

this solves part of #72

Also makes mainFields configurable when using register.
The naming is open to bikeshedding…

@codecov
Copy link

codecov bot commented Jan 24, 2019

Codecov Report

Merging #73 into master will increase coverage by 0.83%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #73      +/-   ##
==========================================
+ Coverage   89.83%   90.66%   +0.83%     
==========================================
  Files           8        8              
  Lines         305      300       -5     
  Branches      108      105       -3     
==========================================
- Hits          274      272       -2     
+ Misses         31       28       -3
Impacted Files Coverage Δ
src/config-loader.ts 96% <ø> (ø) ⬆️
src/match-path-sync.ts 95.65% <100%> (+4.16%) ⬆️
src/mapping-entry.ts 100% <100%> (ø) ⬆️
src/match-path-async.ts 89.06% <100%> (+1.37%) ⬆️
src/filesystem.ts 92% <0%> (-0.86%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6beaeaf...623cd1f. Read the comment docs.

@Swatinem
Copy link
Contributor Author

@jonaskello can we make some progress here? The PR has been open for 6 days…

Also, we discovered a real bug when using the match-all in our register hook:

  1. fork-ts-checker-webpack-plugin does a require('tslint')
  2. tsconfig-paths’ match-all rule resolves this to <root>/tslint.json
  3. things blow up because obviously you wanted to require the tslint module, and not your tslint config file…

@tomspeak
Copy link

tomspeak commented Feb 5, 2019

Facing this issue too. Start up time takes a huge hit when requiring tsconfig-paths.

@jonaskello
Copy link
Member

Ok lets merge this, sorry for the delay!

@jonaskello jonaskello merged commit 6da68cb into dividab:master Feb 5, 2019
@jonaskello
Copy link
Member

Published in 3.8.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants