Copied webpack 5 types into plugins.temp.types.ts
#70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Assigned them as it should be from webpack. Kept legacy code in place (should depreciate)
jonaskello
reviewed
Mar 15, 2021
| @@ -603,11 +603,16 @@ | |||
| resolved "https://registry.yarnpkg.com/@types/json5/-/json5-0.0.29.tgz#ee28707ae94e11d2b827bcbe5270bcea7f3e71ee" | |||
| integrity sha1-7ihweulOEdK4J7y+UnC86n8+ce4= | |||
|
|
|||
| "@types/node@*", "@types/node@^14.14.33": | |||
| "@types/node@*": | |||
There was a problem hiding this comment.
"@types/node@*" and "@types/node@^14.14.34" could probably be joined? Yarn seems to do strange things with * deps sometimes. If you delete both these and re-run yarn I think it will join them.
There was a problem hiding this comment.
Hrm. I ran yarm remove @types/node ; yarn install --deps @types/yarn
Honestly, I avoid Yarn these days, so I might be missing something.
Everyone still uses the Yarn 1x and it's just not developed. Yarn 2 seems like a hot mess still. :/
This was referenced Mar 16, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This typing pass makes pretty much all the typings in the code run as expected.
To do this, I copied over the webpack types and shoved them in a temp typings file for use.
Not the greatest, but it is way more typesafe.
It also seemed that the types were wrong in a couple of places. The code worked fine, so looking into it there were callbacks with an Object instead of the typed String.