Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove warning on missing baseUrl, which tsconfig-paths ^4.0.0 doesn't require anymore #105

Merged
merged 2 commits into from
Jul 11, 2023

Conversation

sverweij
Copy link
Contributor

@sverweij sverweij commented Jul 1, 2023

description

  • removes the check & associated warning on a missing baseUrl in tsconfig.json
  • ensures plugin loading & executing commences even in the absence of a baseUrl

motivation & context

fixes #99 (& fixes #59 - which seems a duplicated of the former)

... which follows from tsconfig-paths PR #208 which makes tsconfig-paths tolerate empty/ non-existing baseUrl's,
... which is consistent with TypeScript >=4.1 behavior
... on which frameworks (like next.js) and newer projects are starting to rely

how this was tested

  • green ci ( ⏳ )
  • manual validation with a local install of tsconfig-paths-webpack-plugin

@sverweij sverweij changed the title Remove warning on missing baseUrl, which tsconfig-paths ^4.0.0 doesn' require anymore Remove warning on missing baseUrl, which tsconfig-paths ^4.0.0 doesn't require anymore Jul 1, 2023
@jonaskello
Copy link
Member

Released in 4.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Warning on missing baseUrl in 4.0.0 even though it can be undefined Support TypeScript 4.1
2 participants