Replaces .env with config.toml #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also removes config.toml automatic editing
|
This looks fine but the envFile branch in the OGREE-CLI already includes this with the changes to use environment variables |
…s also fixes flag parsing bug in config.go
|
There was a flag parsing bug here so this was fixed. The JSON library was used here for the decoding into conf struct since this is better than a manual written solution. repl.go was refactored and now main.go has the init section |
denizul
reviewed
Apr 14, 2023
CLI/config/config.go
Outdated
|
|
||
| type Vardef struct { | ||
| Name string | ||
| Value string |
There was a problem hiding this comment.
I think Value should be an interface{} type, if we want to pass numerical variables etc
denizul
approved these changes
Apr 14, 2023
helderbetiol
added a commit
that referenced
this pull request
Jun 14, 2024
* feat(api) replace - by _ To be uniform with collections and category fields * feat(api) implement virtual objs * fix(back) force remove network on delete tenant * feat(cli) add virtual objs * feat(app) add virtual objs * feat(app) add translations * fix(cli) replace - by _ * fix(cli) replace - by _ * fix(api) get phierarchy with vobj * fix(api) vobj always with tags * feat(cli) add layers to virtual * feat(api) adjustments for virtual * fix(cli) tests * fix(api) tests * refactor(api) simplify validateParent * refactor(cli) simplify name change on virtual root * refactor(cli) simplify layer FromObjects * refactor(cli) simplify update vlinks * feat(cli) add +vobj tests * feat(cli) add vlink update test * feat(cli) test ls vobj * feat(api) update test and doc * refactor(api) improve Cognitive Complexity * fix(api) fix tests
helderbetiol
added a commit
that referenced
this pull request
Jun 20, 2024
* feat(api) replace - by _ To be uniform with collections and category fields * feat(api) implement virtual objs * fix(back) force remove network on delete tenant * feat(cli) add virtual objs * feat(app) add virtual objs * feat(app) add translations * fix(cli) replace - by _ * fix(cli) replace - by _ * fix(api) get phierarchy with vobj * fix(api) vobj always with tags * feat(cli) add layers to virtual * feat(api) adjustments for virtual * fix(cli) tests * fix(api) tests * refactor(api) simplify validateParent * refactor(cli) simplify name change on virtual root * refactor(cli) simplify layer FromObjects * refactor(cli) simplify update vlinks * feat(cli) add +vobj tests * feat(cli) add vlink update test * feat(cli) test ls vobj * feat(api) update test and doc * refactor(api) improve Cognitive Complexity * fix(api) fix tests * Feat476 virtual objects (#2) * feat(api) replace - by _ To be uniform with collections and category fields * feat(api) implement virtual objs * fix(back) force remove network on delete tenant * feat(cli) add virtual objs * feat(app) add virtual objs * feat(app) add translations * fix(cli) replace - by _ * fix(cli) replace - by _ * fix(api) get phierarchy with vobj * fix(api) vobj always with tags * feat(cli) add layers to virtual * feat(api) adjustments for virtual * fix(cli) tests * fix(api) tests * refactor(api) simplify validateParent * refactor(cli) simplify name change on virtual root * refactor(cli) simplify layer FromObjects * refactor(cli) simplify update vlinks * feat(cli) add +vobj tests * feat(cli) add vlink update test * feat(cli) test ls vobj * feat(api) update test and doc * refactor(api) improve Cognitive Complexity * fix(api) fix tests * refactor(api) improve Cognitive Complexity * fix(api) remove duplicate * feat(cli,api) nodes on both namespaces * feat(app) add graph view * feat(app) add graph view * feat(api) update readme * feat(app) add complex filter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The lsog command still tries to read .env, but ziad is fixing it on another branch so I ll just rebase this one once it is done.
Thus the PR should not be merged for now but can already be reviewed.