fix flake8 reported issues, run tests

[sandrobonazzola]

Cleaned up the code, added automated tests.

Not adding all the unit tests at once as they are failing on my laptop. I'll enable all tests in a different PR once this is in.

Coverage report: 25%

coverage.py v6.5.0, created at 2022-10-24 13:57 +0000

Module	statements	missing	excluded	coverage
drop_buffer_cache.py	33	15	0	55%
fallocate.py	35	17	0	51%
parser_data_types.py	49	27	0	45%
smallfile.py	1450	1181	0	19%
smf_test_params.py	98	69	0	30%
sync_files.py	47	36	0	23%
yaml_parser.py	146	57	0	61%
Total	1858	1402	0	25%

coverage.py v6.5.0, created at 2022-10-24 13:57 +0000

Signed-off-by: Sandro Bonazzola [email protected]

[portante]

Was black run on this as well? If so, it might be best to have one commit to see what black did, one for what isort did, and then finally the by-hand changes.

That way, I can review the by-hand changes that were made separate from the automated changes.

[sandrobonazzola]

No, didn't run black. Run flake8 and isort and manually fixed stuff reported there.

[portante]

No, didn't run black. Run flake8 and isort and manually fixed stuff reported there.

Have you considered using black? It'd make these changes much easier to consume in review.

[sandrobonazzola]

pushed an additional commit with black run.

[sandrobonazzola]

Had to drop both isort and flake8 as they don't agree with black.

[portante]

Here is a PR which just applies black and isort without any other changes, #37.

[portante]

If we take that PR in first, and then rebase this PR on that, we'll have just the fixes you have applied which will be a bit easier to review.

[sandrobonazzola]

ok, go ahead merging #37 and I'll rebase.

[sandrobonazzola]

moved to #38 due to master/main rename