Pythonize pbench-log-timestamp #2027
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace shell script with python script and add unit test. Signed-off-by: Charles Short <[email protected]>
|
@zulcss did you mean to close this? |
portante
requested changes
Dec 8, 2020
| @click.command() | ||
| def main(): | ||
| """ Add timestamp to user input""" | ||
| stdin = click.get_text_stream("stdin").read() |
There was a problem hiding this comment.
This needs to be a generator so that stdin can be a pipe and each line read from the pipe is timestamped and written out.
Further, I think we'll want to make sure it is not using buffered I/O so that folks can inspect the output easily as it is generated.
portante
added
Agent
Code Infrastructure
enhancement
tools
|
I'll own driving this change into the repository. |
|
At this point, I think it's safe to say that this PR will never be merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace shell script with python script and add unit test.
Signed-off-by: Charles Short [email protected]