-
Notifications
You must be signed in to change notification settings - Fork 8
Integrate dynamic routing via UmiJS #172
Integrate dynamic routing via UmiJS #172
Conversation
982fcc1
to
24e2a5a
Compare
@aquibbaig @anishaswain keep in mind these changes do not include dynamic routing for the run comparison page due to the size of data payloads to reproduce the page. We'll need to come up with a clever way of rebuilding the page using either a compressed version of the original payload or only rebuild a subset of the run comparison page for dynamic links. |
I think appending to the URL is a bad idea |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for now. But we need to think about how to compress large payloads for result comparison.
@anishaswain what would be the state of run comparisons for now? (what route will they be in) |
url params Update page components to handle reading from local props and window URL to parse data payloads
24e2a5a
to
f5f2d66
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are not using UmiJS anymore in the new dashboard. |
This integration allows page components to handle reading from local props and window URL to parse data payloads. Additionally, this removes the notion of a "private" route and introduces the "overview" naming schema for routes to provide insight into a user's incoming runs to pbench.