Skip to content
This repository has been archived by the owner on Aug 31, 2022. It is now read-only.

Integrate dynamic routing via UmiJS #172

Conversation

gurbirkalsi
Copy link
Collaborator

@gurbirkalsi gurbirkalsi commented Jun 22, 2021

This integration allows page components to handle reading from local props and window URL to parse data payloads. Additionally, this removes the notion of a "private" route and introduces the "overview" naming schema for routes to provide insight into a user's incoming runs to pbench.

@gurbirkalsi gurbirkalsi force-pushed the nested-routing branch 2 times, most recently from 982fcc1 to 24e2a5a Compare June 22, 2021 03:11
@portante portante linked an issue Jun 22, 2021 that may be closed by this pull request
@portante portante added this to the v3.1.0 milestone Jun 23, 2021
@portante portante added the enhancement New feature or request label Jun 23, 2021
portante
portante previously approved these changes Jun 23, 2021
@gurbirkalsi
Copy link
Collaborator Author

@aquibbaig @anishaswain keep in mind these changes do not include dynamic routing for the run comparison page due to the size of data payloads to reproduce the page. We'll need to come up with a clever way of rebuilding the page using either a compressed version of the original payload or only rebuild a subset of the run comparison page for dynamic links.

@aquibbaig
Copy link
Collaborator

aquibbaig commented Jul 12, 2021

I think appending to the URL is a bad idea

anishaswain
anishaswain previously approved these changes Jul 13, 2021
Copy link
Collaborator

@anishaswain anishaswain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for now. But we need to think about how to compress large payloads for result comparison.

@portante portante assigned anishaswain and unassigned gurbirkalsi Jul 13, 2021
@aquibbaig
Copy link
Collaborator

aquibbaig commented Jul 19, 2021

@anishaswain what would be the state of run comparisons for now? (what route will they be in)

url params

Update page components to handle reading from local props and window URL
to parse data payloads
@anishaswain anishaswain requested review from anishaswain and removed request for anishaswain July 19, 2021 10:34
@anishaswain anishaswain dismissed stale reviews from portante and themself via f5f2d66 July 19, 2021 10:35
Copy link
Collaborator

@anishaswain anishaswain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Having unexpected errors after rebase. Working on it
Screenshot 2021-07-19 at 4 03 45 PM

@anishaswain anishaswain marked this pull request as draft July 19, 2021 10:36
@aquibbaig aquibbaig assigned aquibbaig and unassigned anishaswain Aug 12, 2021
@pravins
Copy link
Member

pravins commented Aug 30, 2022

We are not using UmiJS anymore in the new dashboard.

@pravins pravins closed this Aug 30, 2022
@portante portante added the wontfix This will not be worked on label Aug 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request wontfix This will not be worked on
Projects
None yet
5 participants