Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build containers for pushes to main and only published releases #13

Merged
merged 1 commit into from
Sep 1, 2023

Conversation

webbnh
Copy link
Member

@webbnh webbnh commented Aug 31, 2023

Given that the Action for building containers is fairly intelligent about how it tags them, there is no reason not to build and publish containers for pushes to the main branch. Also, creating a single release goes through four different states, and there is no reason to trigger a container build on every one of them for a single release.

So, this PR adds main to the list of branches for which we build containers and it pares the list of release states down to just published.

@webbnh webbnh added bug Something isn't working enhancement New feature or request infrastructure CI, build, test harness, configuration, etc. labels Aug 31, 2023
@webbnh webbnh requested a review from dbutenhof August 31, 2023 18:03
@webbnh webbnh self-assigned this Aug 31, 2023
@codecov
Copy link

codecov bot commented Aug 31, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (c6492c6) 98.52% compared to head (d244c7f) 98.52%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #13   +/-   ##
=======================================
  Coverage   98.52%   98.52%           
=======================================
  Files           2        2           
  Lines         541      541           
=======================================
  Hits          533      533           
  Misses          8        8           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@dbutenhof dbutenhof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So we don't want to build a container image on a draft release? I suppose it really doesn't matter much.

@webbnh webbnh merged commit 41695d9 into distributed-system-analysis:main Sep 1, 2023
@webbnh webbnh deleted the container-tagging branch September 1, 2023 17:43
@webbnh
Copy link
Member Author

webbnh commented Sep 1, 2023

So we don't want to build a container image on a draft release?

I told myself that, before we create a release, we must have pushed to main at least once (which should now create a container image), and we probably created a tag (which will create another container image), so there should be adequate availability for pre-release testing. (And, to be honest, I'm not even sure which user actions correspond to which triggers. 😝)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request infrastructure CI, build, test harness, configuration, etc.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants