Fix subscripts in polynomial model #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbeleidy
force-pushed
the
fix_subscripts_poly_model
branch
from
869e2b9 to
dc462cf
Compare
|
Hadn't noticed the yarn.lock. Switched to yarn and got rid of the package-lock.json. |
|
Thanks for doing this, merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is for issues #94, #91 & #87 which all seem to be duplicates.
Current
master:Updated
fix_subscripts_poly_model:I just have one concern about this PR since there are no contribution guidelines and no specification of which version of npm to use. My version of npm creates a package-lock.json file which I committed. Please let me know if you want this removed.
I'm happy to make any changes.