Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update scala-xml #237

Merged
merged 1 commit into from
Feb 2, 2023
Merged

Conversation

yanns
Copy link
Contributor

@yanns yanns commented Jan 2, 2023

fix #235
lift-json also depends on scala-xml 1.2.
lift-json is not maintained anymore.
I propose to remove the module.

fix dispatch#235
lift-json also depends on scala-xml 1.2.
lift-json is not maintained anymore.
I propose to remove the module.
@yanns
Copy link
Contributor Author

yanns commented Jan 30, 2023

@farmdawgnation can you authorize the PR checks?

@farmdawgnation
Copy link
Member

farmdawgnation commented Jan 30, 2023 via email

@farmdawgnation
Copy link
Member

PR checks are authorized. Will noodle on how I feel about actually pulling the plug on lift-json support but alas, I'm also one of the key maintainers over there and I'm not sure it's aged particularly well.

@farmdawgnation
Copy link
Member

Checks have all passed... give me a bit to think about the lift-json question.

Copy link
Member

@farmdawgnation farmdawgnation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, though I think I'll have to consider this a major version bump.

@farmdawgnation farmdawgnation merged commit 658a1ba into dispatch:main Feb 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Update scala-xml dependency to version 2
2 participants