iso9660 and squashfs support for parallel writings #245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deitch
force-pushed
the
enable-parallel-iso9660-walk
branch
from
b089d41 to
d73fc2b
Compare
Signed-off-by: Avi Deitcher <[email protected]>
deitch
force-pushed
the
enable-parallel-iso9660-walk
branch
from
d73fc2b to
e408c55
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #244
The iso finalization originally was written without parallelism in mind. Most of it works fine. The inly issue was walking the workspace to finalize. Because it is easier to work with relative paths, it did a
os.Chdir(workspace)followed by afilepath.Walk(".",...). In most cases, this works fine, but if you run in parallel, different threads start changing the current directory and mess up things like creating files or removing files or walking trees.In general,
os.Chdir()is not a friendly thing to do in libraries, so it is good to remove it.Both iso9660 and squashfs did this, so fixed in both places.
Thanks to @mchuang3 for the excellent issue in #244, with a simple recreation.