Introduce custom rules for i18n imports #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidtaylorhq
force-pushed
the
custom-i18n-rule
branch
from
965d49f to
5dbd344
Compare
davidtaylorhq
added a commit
to discourse/discourse
that referenced
this pull request
Nov 19, 2024
Soon, we intend to consolidate all js/gjs translation calls to this new function. See discourse/lint-configs#67 and #29804
davidtaylorhq
added a commit
to discourse/discourse
that referenced
this pull request
Nov 19, 2024
Soon, we intend to consolidate all js/gjs translation calls to this new function. See discourse/lint-configs#67 and #29804
Before:
- `import i18n from discourse-common/helpers/i18n;` -> `i18n()`
- `import I18n from "discourse-i18n";` -> `I18n.t()`
- `import I18n from "i18n";` -> `I18n.t()`
After:
- `import { i18n } from "discourse-i18n";` -> `i18n()`
These rules remain disabled by default. We can enable them by default once discourse/discourse@d606ac3d8e is widely available.
davidtaylorhq
force-pushed
the
custom-i18n-rule
branch
from
d151885 to
c644b93
Compare
davidtaylorhq
changed the title
CvX
approved these changes
Nov 19, 2024
There was a problem hiding this comment.
50% credit goes to AI 😜
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before:
import i18n from discourse-common/helpers/i18n;->i18n()import I18n from "discourse-i18n";->I18n.t()import I18n from "i18n";->I18n.t()After:
import { i18n } from "discourse-i18n";->i18n()These rules remain disabled by default. We can enable them by default once discourse/discourse@d606ac3d8e is widely available.