Skip to content

Commit

Permalink
DEV: Disable broken ember rules, enable one more (#60)
Browse files Browse the repository at this point in the history
  • Loading branch information
CvX authored Jan 12, 2024
1 parent 0b170c7 commit 1503846
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 3 deletions.
5 changes: 3 additions & 2 deletions lint-configs/eslintrc.cjs
Original file line number Diff line number Diff line change
Expand Up @@ -136,15 +136,15 @@ module.exports = {
"ember/require-return-from-computed": "off",
"ember/avoid-using-needs-in-controllers": "error",
"ember/new-module-imports": "error",
"ember/no-deprecated-router-transition-methods": "error",
"ember/no-deprecated-router-transition-methods": "off", // this rule is broken
"ember/no-function-prototype-extensions": "error",
"ember/no-string-prototype-extensions": "error",
"ember/avoid-leaking-state-in-ember-objects": "off",
"ember/no-get": "off",
"ember/no-observers": "off",
"ember/no-mixins": "off",
"ember/no-new-mixins": "off",
"ember/no-implicit-injections": "off",
"ember/no-implicit-injections": "off", // this rule is broken
"ember/no-array-prototype-extensions": "off",
"ember/no-try-invoke": "error",
"ember/require-super-in-lifecycle-hooks": "error",
Expand All @@ -163,6 +163,7 @@ module.exports = {
"ember/no-shadow-route-definition": "off",
"ember/no-unnecessary-index-route": "off",
"ember/no-unnecessary-route-path-option": "error",
"ember/no-unnecessary-service-injection-argument": "error",
"ember/route-path-style": "off",
"ember/routes-segments-snake-case": "off",
"ember/no-pause-test": "error",
Expand Down
2 changes: 1 addition & 1 deletion lint-configs/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@discourse/lint-configs",
"version": "1.3.3",
"version": "1.3.4",
"description": "Shareable lint configs for Discourse core, plugins, and themes",
"author": "Discourse",
"license": "MIT",
Expand Down

0 comments on commit 1503846

Please sign in to comment.