Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEATURE: Add assistant to quick search widget #13650

Merged
merged 6 commits into from
Jul 16, 2021

Conversation

pmusaraj
Copy link
Contributor

@pmusaraj pmusaraj commented Jul 6, 2021

screencast.2021-07-13.11-21-13.mp4

This replaces the autocomplete dropdown for categories and usernames on the search input and insteads adds suggestions for the filters as items in the search results.

As seen in the screencast, typing a partial category name, i.e.shows #do will return autocomplete suggestions in the main results space that the user can select and search for.

The PR adds the same behaviour for @mentions as well as in: status: order: keywords. The following suggestions are included:

in:title
in:personal
in:seen
in:likes
in:bookmarks
in:created

status:open
status:closed
status:public
status:noreplies

order:latest
order:views
order:likes
order:latest_topic

An API function has also been included so that plugins can extend the in: shortcuts. For example, addInSearchShortcut("in:assigned") should allow the assign plugin to show its search filter when it is enabled.

Copy link
Contributor

@eviltrout eviltrout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is very nice! Since it's a fair bit of code let's be sure to merge at a safe time when things are stable.

@pmusaraj pmusaraj merged commit 438a762 into master Jul 16, 2021
@pmusaraj pmusaraj deleted the feature-quick-search-assistant branch July 16, 2021 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants