Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Miscellaneous backports #9769

Merged
merged 9 commits into from
Nov 5, 2023
Merged

Conversation

jaw0r3k
Copy link
Contributor

@jaw0r3k jaw0r3k commented Aug 12, 2023

Please describe the changes this PR makes and why it should be merged:

Backports:

Yeah quite much backported there

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating
  • This PR changes the library's interface (methods or parameters added)
  • This PR includes breaking changes (methods removed or renamed, parameters moved or removed)

@vercel
Copy link

vercel bot commented Aug 12, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
discord-js ⬜️ Ignored (Inspect) Visit Preview Nov 4, 2023 10:21pm
discord-js-guide ⬜️ Ignored (Inspect) Visit Preview Nov 4, 2023 10:21pm

@github-actions
Copy link

github-actions bot commented Aug 12, 2023

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 84
🟢 Accessibility 96
🟢 Best practices 100
🟠 SEO 67
🔴 PWA 33

Lighthouse ran on https://discord-js-git-fork-jaw0r3k-mass-backport-discordjs.vercel.app/

@Qjuh
Copy link
Contributor

Qjuh commented Aug 12, 2023

These are feats added as well, not just fixes. This should be reflected in the PR title. Also backporting so many different things at once means the changelog will mention all of this as just „Miscellaneous fixes“.

@jaw0r3k jaw0r3k changed the title fix: Miscellaneous fixes chore: Miscellaneous backports Aug 12, 2023
@Jiralite Jiralite added this to the discord.js 13.17 milestone Aug 12, 2023
@vladfrangu vladfrangu merged commit 5dd4933 into discordjs:v13 Nov 5, 2023
9 checks passed
@jaw0r3k jaw0r3k deleted the mass-backport branch November 5, 2023 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants