-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
types: Allow choice's value type to be strictly inferred #8529
types: Allow choice's value type to be strictly inferred #8529
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
Codecov Report
@@ Coverage Diff @@
## main #8529 +/- ##
==========================================
+ Coverage 78.73% 86.45% +7.72%
==========================================
Files 22 87 +65
Lines 3503 8462 +4959
Branches 320 1105 +785
==========================================
+ Hits 2758 7316 +4558
- Misses 741 1103 +362
- Partials 4 43 +39
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some tests for these would be nice 🙏
Please describe the changes this PR makes and why it should be merged:
The following code will not yield an error despite the type of the option being known:
This pull request strengthens the types around here and resolves #8528.
Status and versioning classification: