feat(GuildMember): Added communicationDisabledUntil property #6949
Conversation
| if (_data.communicationDisabledUntil) { | ||
| if (_data.communicationDisabledUntil instanceof Date) { | ||
| _data.communication_disabled_until = _data.communicationDisabledUntil; | ||
| if(_data.communication_disabled_until.getTime() < Date.now()) throw new Error('COMMUNICATION_DISABLED_PAST_DATE'); |
There was a problem hiding this comment.
Discord accepts dates in the past currently (and doesn't reset on sending null), so the lib shouldn't throw
| if(_data.communication_disabled_until.getTime() < Date.now()) throw new Error('COMMUNICATION_DISABLED_PAST_DATE'); | ||
| } else { | ||
| _data.communication_disabled_until = new Date(Date.now() + _data.communicationDisabledUntil * 1000); | ||
| if(_data.communication_disabled_until.getTime() < Date.now()) throw new Error('COMMUNICATION_DISABLED_PAST_DATE'); |
| @@ -150,6 +150,9 @@ const Messages = { | |||
| NOT_IMPLEMENTED: (what, name) => `Method ${what} not implemented on ${name}.`, | |||
|
|
|||
| SWEEP_FILTER_RETURN: 'The return value of the sweepFilter function was not false or a Function', | |||
|
|
|||
| COMMUNICATION_DISABLED_PAST_DATE: 'The given date can\'t be in the past', | |||
| COMMUNICATION_DISABLED_NEGATIVE_DURATION: 'The given duration can\' be negative', | |||
|
I feel like the terms "muted" and "unmuted" shouldn't be used here, but we'll wait for UI descriptions to see what we can replace them with, if at all. |
|
Please add the PR to the description: discord/discord-api-docs#4075 |
|
Discord released a "MODERATE_MEMBERS" permission - this should be added to this PR |
| * Disables or enables communication for this member. | ||
| * @param {?number | Date} seconds The duration in seconds or a date in the future until the member should have | ||
| * their communication disabled. Passing `null` will enable communication for them. | ||
| * @param {string} [reason] Reason for setting the nickname |
There was a problem hiding this comment.
Typo as a nickname is not set here, but instead the reason for the mute.
|
|
||
| /** | ||
| * Disables or enables communication for this member. | ||
| * @param {?number | Date} seconds The duration in seconds or a date in the future until the member should have |
There was a problem hiding this comment.
The documentation doesn't render the ? properly otherwise
| * @param {?number | Date} seconds The duration in seconds or a date in the future until the member should have | |
| * @param {?(number|Date)} seconds The duration in seconds or a date in the future until the member should have |
| * @param {string} [reason] Reason for setting the nickname | ||
| * @returns {Promise<GuildMember>} | ||
| */ | ||
| disableCommunication(seconds, reason) { |
There was a problem hiding this comment.
The name of the first argument doesn't match the one in the typings
Not to mention that seconds sounds misleading since it accepts dates
|
@ZeldaFan0225 are you no longer going to maintain this PR? |
|
@ImRodry no thats why i closed |
Please describe the changes this PR makes and why it should be merged:
This PR includes the already present communication_disabled_until property returned by the API.
This should be merged so as soon Discord releases that feature people can use it.
Relevant PR in discord-api-docs:
Status and versioning classification: