fix(InviteDelete): guild can be missing #5457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🤙 |
iCrawl
approved these changes
Mar 31, 2021
iCrawl
pushed a commit
that referenced
this pull request
Mar 31, 2021
|
The issue still persists even after updating the library |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
The recent addition of stage channels has brought up a bug in our handling of the
INVITE_DELETE. We currently only return if both the channel as well as the guild can not be found in the cache, however, according to upstream documentationguild_id?can be missing.We should instead return if the channel can not be found, no matter if the guild can be.
Trivia: came to light, since currently stage channels never enter the cache to begin with, meaning it can never be retrieved here.
Status and versioning classification:
Please move lines that apply to you out of the comment: