Move Guild#defaultRole to RoleStore#everyone

[didinele]

Please describe the changes this PR makes and why it should be merged:
Moves Guild#defaultRole to RoleStore, which suits the use of stores far better.
Also renames it to everyone, as others have suggested.

Status

• Code changes have been tested against the Discord API, or there are no code changes
• I know how to update typings and have done so, or typings don't need updating

Semantic versioning classification:

• This PR changes the library's interface (methods or parameters added)
  • This PR includes breaking changes (methods removed or renamed, parameters moved or removed)
• This PR only includes non-code changes, like changes to documentation, README, etc.

[jpbberry]

My original idea btw.
Also I suggest it being RoleStore.everyone rather than .defaultRole

[tipakA]

defaultRole leaves that tiny bit of space in case when Discord would out of the blue change naming of roles

[appellation]

This is a case where it would be nice if default wasn't a reserved keyword. As it is, I don't see any way to reasonably avoid the naming redundancy here. 👍

[didinele]

Absolutely, the question still stands, should we keep .defaultRole, or change it to .everyone.

I personally think defaultRole is the better option.

[vladfrangu]

@appellation excuse my usage of notepad, but default doesn't seem to cause an issue in the class, neither with or without strict mode enabled (this is on node.js v12.3.1).

Surprisingly... None of the keywords seem to trigger an error in the code.. I am able to use get followed by true, false, null, class, function without an issue... Could this be an issue with older node.js versions?

EDIT: Tested on node.js 10.13.0 by @kyranet, result:

[appellation]

I wasn't suggesting that we should avoid default because it doesn't work. I believe it is poor design to use keywords in identifiers even if the interpreter allows it.

[SpaceEEC]

Is there any reason for it to be called defaultRole?
Skimming through Discord's documentation for guild yields two results for @everyone, and none for default.

Was it maybe only for consistency with the now "deceased" default channel?
If so, everyone might actually be a reasonable choice.

[didinele]

Any more discussion on this? Should I change it into everyone like Space suggested?

[didinele]

All said and done!