Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ThreadMember): remove audit log reason parameter #10023

Merged
merged 4 commits into from
Oct 1, 2024
Merged

fix(ThreadMember): remove audit log reason parameter #10023

merged 4 commits into from
Oct 1, 2024

Conversation

Renegade334
Copy link
Contributor

Please describe the changes this PR makes and why it should be merged:
The Add Thread Member and Remove Thread Member endpoints do not create audit log entries, and therefore do not accept the X-Audit-Log-Reason header.

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating
  • This PR includes breaking changes (methods removed or renamed, parameters moved or removed)

@Renegade334 Renegade334 requested a review from a team as a code owner December 3, 2023 19:18
@vercel Vercel
Copy link

vercel bot commented Dec 3, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
discord-js ⬜️ Ignored (Inspect) Visit Preview Oct 1, 2024 4:30pm
discord-js-guide ⬜️ Ignored (Inspect) Visit Preview Oct 1, 2024 4:30pm

@Renegade334 Renegade334 mentioned this pull request Dec 28, 2023
Merged
@Jiralite
Copy link
Member

Please resolve conflicts!

@Renegade334
Copy link
Contributor Author

Will rebase when I get the chance. 👍

@Renegade334 Renegade334 force-pushed the threadmember-addremove-no-reason branch 2 times, most recently from 0d94333 to 19b93a2 Compare December 29, 2023 15:37
@vladfrangu vladfrangu force-pushed the threadmember-addremove-no-reason branch from 19b93a2 to 9a33cbe Compare January 13, 2024 11:03
@Jiralite Jiralite added this to the discord.js 15.0.0 milestone Jul 31, 2024
@Jiralite Jiralite removed the blocked label Oct 1, 2024
@kodiakhq kodiakhq bot merged commit b339a7c into discordjs:main Oct 1, 2024
7 checks passed
@Renegade334 Renegade334 deleted the threadmember-addremove-no-reason branch October 1, 2024 23:13
@Jiralite Jiralite mentioned this pull request Oct 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaw0r3k jaw0r3k jaw0r3k approved these changes

@Jiralite Jiralite Jiralite approved these changes

@kyranet kyranet kyranet approved these changes

@iCrawl iCrawl iCrawl approved these changes

@vladfrangu vladfrangu vladfrangu approved these changes

@SpaceEEC SpaceEEC Awaiting requested review from SpaceEEC SpaceEEC is a code owner automatically assigned from discordjs/core

Assignees
No one assigned
Labels
packages:discord.js semver:major
Projects
discord.js
Archived in project
Milestone
discord.js 15.0.0
Development

Successfully merging this pull request may close these issues.
6 participants
@Renegade334 @Jiralite @vladfrangu @iCrawl @kyranet @jaw0r3k