fix(InteractionResponses): check if ephemeral message flag is used #10021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Ignored Deployments
|
sdanialraza
force-pushed
the
fix/check-if-ephemeral-message-flag-is-used
branch
2 times, most recently
from
e8a4e6c
to
67360a9
Compare
vladfrangu
requested changes
Dec 3, 2023
didinele
requested changes
Dec 3, 2023
packages/discord.js/src/structures/interfaces/InteractionResponses.js
Outdated
Show resolved
Hide resolved
sdanialraza
force-pushed
the
fix/check-if-ephemeral-message-flag-is-used
branch
from
67360a9
to
d922e34
Compare
sdanialraza
force-pushed
the
fix/check-if-ephemeral-message-flag-is-used
branch
from
d922e34
to
94d6932
Compare
didinele
requested changes
Dec 4, 2023
Nothing to address haha, iirc deferReply doesnt support all flags |
vladfrangu
approved these changes
Dec 4, 2023
|
Yeah, it was addressed internally, there's no flags property for options in deferReply |
didinele
approved these changes
Dec 4, 2023
Jiralite
approved these changes
Dec 4, 2023
This was referenced Aug 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
Resolves #10020
Status and versioning classification: