Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(AllowedMentions): add support for MessageOptions#allowedMentions #3893

Merged
merged 12 commits into from
Mar 19, 2020
Merged

feat(AllowedMentions): add support for MessageOptions#allowedMentions #3893

merged 12 commits into from
Mar 19, 2020

Conversation

monbrey
Copy link
Member

@monbrey monbrey commented Mar 4, 2020

Ref: discord/discord-api-docs#1396

Status

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

Semantic versioning classification:

  • This PR changes the library's interface (methods or parameters added)
    • This PR includes breaking changes (methods removed or renamed, parameters moved or removed)
  • This PR only includes non-code changes, like changes to documentation, README, etc.

@monbrey monbrey changed the title feat(allowedmentions): add support for messageoptions#allowedmentions feat(AllowedMentions): add support for MessageOptions#allowedMentions Mar 4, 2020
@tipakA
Copy link
Contributor

tipakA commented Mar 4, 2020

Wouldn't there be a way to actually use those for disableMentions client option? According to the example from discord api documentation:
image
First example fits perfectly into disableMentions: 'all', while second fits disableMentions: 'everyone'

@monbrey
Copy link
Member Author

monbrey commented Mar 4, 2020

In theory yes, but this isn't supposed to replace existing functionality that already works in a specific way.

This is a new MessageOption and should be implemented as one imo

NotSugden
NotSugden suggested changes Mar 8, 2020
View reviewed changes
typings/index.d.ts Outdated Show resolved Hide resolved
@Khaaz Khaaz mentioned this pull request Mar 8, 2020
Merged
7 tasks
SpaceEEC
SpaceEEC requested changes Mar 8, 2020
View reviewed changes
src/structures/APIMessage.js Outdated Show resolved Hide resolved
src/structures/APIMessage.js Outdated Show resolved Hide resolved
src/structures/APIMessage.js Outdated Show resolved Hide resolved
src/structures/APIMessage.js Outdated Show resolved Hide resolved
@SpaceEEC SpaceEEC linked an issue Mar 8, 2020 that may be closed by this pull request
disable non-mentionable role mentions #3882
Closed
NotSugden
NotSugden reviewed Mar 9, 2020
View reviewed changes
src/structures/APIMessage.js Outdated Show resolved Hide resolved
src/structures/APIMessage.js Outdated Show resolved Hide resolved
@iCrawl iCrawl requested a review from SpaceEEC March 17, 2020 08:31
SpaceEEC
SpaceEEC requested changes Mar 17, 2020
View reviewed changes
src/structures/APIMessage.js Outdated Show resolved Hide resolved
@monbrey monbrey requested a review from SpaceEEC March 17, 2020 21:47
@iCrawl iCrawl merged commit df324e2 into discordjs:master Mar 19, 2020
@snyk-bot snyk-bot mentioned this pull request Apr 2, 2020
Merged
@monbrey monbrey deleted the allowed-mentions branch April 15, 2020 02:13
@maybeanerd maybeanerd mentioned this pull request Apr 21, 2020
Merged
@snyk-bot snyk-bot mentioned this pull request Apr 28, 2020
Merged
@snyk-bot snyk-bot mentioned this pull request May 6, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NotSugden NotSugden NotSugden requested changes

@SpaceEEC SpaceEEC SpaceEEC approved these changes

@iCrawl iCrawl iCrawl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

disable non-mentionable role mentions
5 participants
@monbrey @tipakA @iCrawl @SpaceEEC @NotSugden