Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add timeout-related fields to Modify Guild Member JSON body #288

Closed
wants to merge 1 commit into from
Closed

Add timeout-related fields to Modify Guild Member JSON body #288

wants to merge 1 commit into from

Conversation

bleonard252
Copy link
Contributor

Please describe the changes this PR makes and why it should be merged: communication_disabled_until is an accepted field in the "Modify Guild Member" JSON body. This is a minor change that updates the corresponding type in API v8 and v9 to reflect that.

Reference Discord API Docs PRs or commits:
discord/discord-api-docs#4075

@vladfrangu
Copy link
Member

Please run the deno build script

@bleonard252
Copy link
Contributor Author

I'm not sure how I just realized this repository has a strict commit name rule, so I'm gonna close this PR and re-commit to conform.

@bleonard252 bleonard252 closed this Jan 7, 2022
@imranbarbhuiya
Copy link
Contributor

imranbarbhuiya commented Jan 7, 2022

I'm not sure how I just realized this repository has a strict commit name rule, so I'm gonna close this PR and re-commit to conform.

Why creating a new pr you can change commit message using

git --amend 

Iirc

@vladfrangu
Copy link
Member

By the way, you don't have to worry about your commit names, they'll get squashed when I merge 😁

@bleonard252
Copy link
Contributor Author

I changed the commit name in the original branch but the PR isn't picking it up for some reason. Also how the heck do I run the deno build script? I haven't used deno before (yet).

@vladfrangu
Copy link
Member

You can reopen this PR or a new one

For the deno side.. install the dependencies from this project and when committing..the hooks should run (unless you use Gh desktop). In that case, just run the build:deno npm script

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants